Added hardware_interface ver 5.x.x support #1042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: soham2560
Contributor
Author
|
@omichel can you have another look at this, have added support for ver5.3 as well, refer added ver5.3 support the failing test seems to be unrelated, will merge after your review. On a side note, is there going to be a release of webots_ros2_control soon? |
omichel
requested changes
Jul 10, 2025
webots_ros2_control/include/webots_ros2_control/Ros2ControlSystem.hpp
Outdated
Show resolved
Hide resolved
Member
|
I have no plan for a new release of |
omichel
requested changes
Jul 10, 2025
Co-authored-by: Olivier Michel <[email protected]>
Co-authored-by: Olivier Michel <[email protected]>
omichel
approved these changes
Jul 10, 2025
Member
|
Sorry, I started Kilted and Rolling support for a release here: I will get back to it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: soham2560
Description
There is a Build Error for webots_ros2_control on Rolling as described in #1041. Seems to be from the recent update to 5.0.0 and above for versions (refer ros-controls/ros2_control@151b22e)
After some thought, have decided to also add support for ver5.3 here, as it introduces updated API.
Related Issues
This pull-request fixes issue #1041
Affected Packages
List of affected packages: